fix(unit): enhance selenium retry logic and verification for search, sent, unread, contacts, and history pages #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
force-pushed
the
fixed-selenium-16
branch
29 times, most recently
from
8b8c988 to
c801c21
Compare
|
Yes, this sounds like the right approach to me. I'll merge and see how it behaves on different PRs. Thanks a lot! |
|
However, the pipeline still fails. Can you make sure to run it several times after you push your fixes and mark it for review? |
Shadow243
force-pushed
the
fixed-selenium-16
branch
14 times, most recently
from
94caeb9 to
3b2edde
Compare
Shadow243
force-pushed
the
fixed-selenium-16
branch
6 times, most recently
from
50adf24 to
6228656
Compare
…read, contacts, and history pages
Shadow243
force-pushed
the
fixed-selenium-16
branch
from
6228656 to
b370add
Compare
|
@Shadow243 see my attempt here: #1760 It is almost done. I still see one one intermittent error that happens in some of the runs - pages test, all up to search is fine, then unread is stuck and a few after it. It seems the navigation completes but the page doesn't update. I've added artifacts of all tests that were run and similar things that should be helpful to debug. When you can, please check it out and commit what you think will fix it to run 100% of the times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1719 (comment)
This fix bridges the gap between modern Single Page Application navigation patterns and traditional browser automation tools